“The photos in My Photo Stream are already stored on at least one of your devices, so as long as you have the device with your originals, you won’t lose any photos as part of this process,” Apple notes on its support page.

That’s why I always have multiple local backups

So this is an old legacy thing in Photos on the Mac? This feels like a non issue